Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match blittability rules in crossgen2 with CoreCLR #2072

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Match blittability rules in crossgen2 with CoreCLR #2072

merged 1 commit into from
Jan 23, 2020

Conversation

MichalStrehovsky
Copy link
Member

Fixes #483. Structs with pointer-typed fields are blittable.

After #1866 we no longer have to worry about the recursion because the code path that recursed into pointed-to types was deleted.

Cc @dotnet/crossgen-contrib

@MichalStrehovsky
Match blittability rules in crossgen2 with CoreCLR
a940863 
Fixes #483. Structs with pointer-typed fields are blittable.

After #1866 we no longer have to worry about the recursion because the code path that recursed into pointed-to types was deleted.
@MichalStrehovsky MichalStrehovsky merged commit 1216311 into master Jan 23, 2020
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch January 23, 2020 19:07
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MarshalUtils.IsBlittable does not handle pointers correctly
3 participants
@MichalStrehovsky @jkotas @Dotnet-GitSync-Bot